[CLOSED] Call to modders/mappers: "One Room" round robin!

Talk about creating Grimrock 1 levels and mods here. Warning: forum contains spoilers!
User avatar
Xanathar
Posts: 629
Joined: Sun Apr 15, 2012 10:19 am
Location: Torino, Italy
Contact:

Re: [CLOSED] Call to modders/mappers: "One Room" round robin

Post by Xanathar »

Please ignore ALL of the above regarding x. :o

And everybody in heaven all sing glory songs to Komag :lol: :lol:

This is exactly an instance of the same bug Komag is having with the allEntities iterator - simply the allEntities(1) iterator doesn't return the grim_dragon object for some reason.

Image
Waking Violet (Steam, PS4, PSVita, Switch) : http://www.wakingviolet.com

The Sunset Gate [MOD]: viewtopic.php?f=14&t=5563

My preciousss: http://www.moonsharp.org
User avatar
Skuggasveinn
Posts: 562
Joined: Wed Sep 26, 2012 5:28 pm

Re: [CLOSED] Call to modders/mappers: "One Room" round robin

Post by Skuggasveinn »

The mod has been updated on Nexus to version 1.1

Fixes are
SpoilerShow
Meretifh got the source and changed his room abit, more clues as to how the scrolls should be ordered, and it was removed that you need to place the book on the pedestal .....

When you go into BeNNyBiLL's room the door will close behind you as it did before, put when you complete the puzzle both doors open (to continue and to go back). This will allow people to go back to the library if they missed it.
Skuggasveinn.
Link to all my LoG 2 assets on Nexus.
Link to all my LoG 1 assets on Nexus.
User avatar
Komag
Posts: 3658
Joined: Sat Jul 28, 2012 4:55 pm
Location: Boston, USA

Re: [CLOSED] Call to modders/mappers: "One Room" round robin

Post by Komag »

sounds good, but perhaps it will need 1.2 to change Grimwold's allEntities to 0,31 loops of entitiesAt
Finished Dungeons - complete mods to play
User avatar
Skuggasveinn
Posts: 562
Joined: Wed Sep 26, 2012 5:28 pm

Re: [CLOSED] Call to modders/mappers: "One Room" round robin

Post by Skuggasveinn »

Komag wrote:sounds good, but perhaps it will need 1.2 to change Grimwold's allEntities to 0,31 loops of entitiesAt
I'm all for fixing this issue, but this falls way outoff my scripting league :)
If someone wants to send me the complete new script with the fix, I can paste it in, or I can send someone a link to the source if that persons wants to go in and fix this (Grimwold !!! you want the source ??? )

Skuggasveinn.
Link to all my LoG 2 assets on Nexus.
Link to all my LoG 1 assets on Nexus.
User avatar
Xanathar
Posts: 629
Joined: Sun Apr 15, 2012 10:19 am
Location: Torino, Italy
Contact:

Re: [CLOSED] Call to modders/mappers: "One Room" round robin

Post by Xanathar »

We can apply the solution Marble Mouth gave here: viewtopic.php?f=14&t=5028&sid=0ba1d92c6 ... e58#p53889

I can do it later today or tomorrow, but if anyone has more available time is welcome :)

Besides Grimwold's room, also (I think) JohnWordsworth and HaunterV ones are using allEntities in scripts so they might be affected (I just had a quick search on dungeon.lua, so I might be wrong on which room has which script :) ).
Waking Violet (Steam, PS4, PSVita, Switch) : http://www.wakingviolet.com

The Sunset Gate [MOD]: viewtopic.php?f=14&t=5563

My preciousss: http://www.moonsharp.org
User avatar
SpiderFighter
Posts: 789
Joined: Thu Apr 12, 2012 4:15 pm

Re: [CLOSED] Call to modders/mappers: "One Room" round robin

Post by SpiderFighter »

Congrats guys!! This is exciting. :) Have you had any feedback from it yet?
User avatar
Merethif
Posts: 274
Joined: Tue Apr 24, 2012 1:58 pm
Location: Poland

Re: [CLOSED] Call to modders/mappers: "One Room" round robin

Post by Merethif »

SpiderFighter wrote:Congrats guys!! This is exciting. :) Have you had any feedback from it yet?
Hi there! Yes, there's a feedback thread:
viewtopic.php?f=14&t=4982
User avatar
Grimwold
Posts: 511
Joined: Thu Sep 13, 2012 11:45 pm
Location: A Dungeon somewhere in the UK

Re: [CLOSED] Call to modders/mappers: "One Room" round robin

Post by Grimwold »

Just to confirm.. the problem with my room is definitely the allEntities() and Map Marker issue... I loaded up Ryeath_Greystalk's save game, removed his map markers and was able to play my room no problem.

From Petrii's comments it sounds like it will be a bit before the patch for this goes live, so perhaps using Komag's work-around is the best option.
viewtopic.php?f=14&t=5028&start=10#p53907
User avatar
JohnWordsworth
Posts: 1397
Joined: Fri Sep 14, 2012 4:19 pm
Location: Devon, United Kingdom
Contact:

Re: [CLOSED] Call to modders/mappers: "One Room" round robin

Post by JohnWordsworth »

Wow, what an obscure bug. It sounds like Marble Mouth's solution is the way to go (essentially as an extension to Komag's solution). By redefining the allEntities() method we essentially guarantee the problem fixed for any code that runs after the redefinition. I assume redefining global functions works well with save files.
My Grimrock Projects Page with links to the Grimrock Model Toolkit, GrimFBX, Atlas Toolkit, QuickBar, NoteBook and the Oriental Weapons Pack.
User avatar
Skuggasveinn
Posts: 562
Joined: Wed Sep 26, 2012 5:28 pm

Re: [CLOSED] Call to modders/mappers: "One Room" round robin

Post by Skuggasveinn »

map markers :) who would have thought .....

I've PM'ed Grimwold the link to the latest build, if we want to get this released on steam I think its a good idea take care of this bug with some workaround, and like Grimwold said it looks from Petri's words that the fix for this will not come for a while.

Skuggasveinn.
Link to all my LoG 2 assets on Nexus.
Link to all my LoG 1 assets on Nexus.
Post Reply